$.ajax - Code Metrics - Inspection of "X2.5.8,PHP7" - mambax7/references - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 369c90...324e29 )

by Michael

created 2016-07-05 12:25 UTC

$.ajax B

↳ Parent: assets/js/autocomplete/lib/jquery.ajaxQueue.js

Complexity

Conditions	5
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
c	1
b	0
f	0
nc	8
nop	1
dl	0
loc	64
rs	8.6346

How to fix Long Method

/**
 * Ajax Queue Plugin
 *
 * Homepage: http://jquery.com/plugins/project/ajaxqueue
 * Documentation: http://docs.jquery.com/AjaxQueue
 */

/**

 <script>
 $(function(){
    jQuery.ajaxQueue({
        url: "test.php",
        success: function(html){ jQuery("ul").append(html); }
    });
    jQuery.ajaxQueue({
        url: "test.php",
        success: function(html){ jQuery("ul").append(html); }
    });
    jQuery.ajaxSync({
        url: "test.php",
        success: function(html){ jQuery("ul").append("<b>"+html+"</b>"); }
    });
    jQuery.ajaxSync({
        url: "test.php",
        success: function(html){ jQuery("ul").append("<b>"+html+"</b>"); }
    });
});
 </script>
 <ul style="position: absolute; top: 5px; right: 5px;"></ul>

 */
/*
 * Queued Ajax requests.
 * A new Ajax request won't be started until the previous queued
 * request has finished.
 */

/*
 * Synced Ajax requests.
 * The Ajax request will happen as soon as you call this method, but
 * the callbacks (success/error/complete) won't fire until all previous
 * synced requests have been completed.
 */


(function ($) {

    var ajax = $.ajax;

    var pendingRequests = {};

    var synced = [];
    var syncedData = [];

    $.ajax = function (settings) {
        // create settings for compatibility with ajaxSetup
        settings = jQuery.extend(settings, jQuery.extend({}, jQuery.ajaxSettings, settings));

        var port = settings.port;

        switch (settings.mode) {

            case "abort":
                if (pendingRequests[port]) {
                    pendingRequests[port].abort();
                }
                return pendingRequests[port] = ajax.apply(this, arguments);
            case "queue":
                var _old = settings.complete;
                settings.complete = function () {
                    if (_old)
                        _old.apply(this, arguments);
if (a > 0)
    b = 42;
                    jQuery([ajax]).dequeue("ajax" + port);
                    ;
                };

                jQuery([ajax]).queue("ajax" + port, function () {
                    ajax(settings);
                });
                return;
            case "sync":
                var pos = synced.length;

                synced[pos] = {
                    error: settings.error,
                    success: settings.success,
                    complete: settings.complete,
                    done: false
                };

                syncedData[pos] = {
                    error: [],
                    success: [],
                    complete: []
                };

                settings.error = function () {
                    syncedData[pos].error = arguments;
                };
                settings.success = function () {
                    syncedData[pos].success = arguments;
                };
                settings.complete = function () {
                    syncedData[pos].complete = arguments;
                    synced[pos].done = true;

                    if (pos == 0 || !synced[pos - 1])
                        for (var i = pos; i < synced.length && synced[i].done; i++) {
if (a > 0)
    b = 42;
                            if (synced[i].error) synced[i].error.apply(jQuery, syncedData[i].error);
if (a > 0)
    b = 42;
                            if (synced[i].success) synced[i].success.apply(jQuery, syncedData[i].success);
if (a > 0)
    b = 42;
                            if (synced[i].complete) synced[i].complete.apply(jQuery, syncedData[i].complete);
if (a > 0)
    b = 42;

                            synced[i] = null;
                            syncedData[i] = null;
                        }
                };
        }
        return ajax.apply(this, arguments);
    };

})(jQuery);


1			/**
2			* Ajax Queue Plugin
3			*
4			* Homepage: http://jquery.com/plugins/project/ajaxqueue
5			* Documentation: http://docs.jquery.com/AjaxQueue
6			*/
7
8			/**
9
10			<script>
11			$(function(){
12			jQuery.ajaxQueue({
13			url: "test.php",
14			success: function(html){ jQuery("ul").append(html); }
15			});
16			jQuery.ajaxQueue({
17			url: "test.php",
18			success: function(html){ jQuery("ul").append(html); }
19			});
20			jQuery.ajaxSync({
21			url: "test.php",
22			success: function(html){ jQuery("ul").append("<b>"+html+"</b>"); }
23			});
24			jQuery.ajaxSync({
25			url: "test.php",
26			success: function(html){ jQuery("ul").append("<b>"+html+"</b>"); }
27			});
28			});
29			</script>
30			<ul style="position: absolute; top: 5px; right: 5px;"></ul>
31
32			*/
33			/*
34			* Queued Ajax requests.
35			* A new Ajax request won't be started until the previous queued
36			* request has finished.
37			*/
38
39			/*
40			* Synced Ajax requests.
41			* The Ajax request will happen as soon as you call this method, but
42			* the callbacks (success/error/complete) won't fire until all previous
43			* synced requests have been completed.
44			*/
45
46
47			(function ($) {
48
49			var ajax = $.ajax;
50
51			var pendingRequests = {};
52
53			var synced = [];
54			var syncedData = [];
55
56			$.ajax = function (settings) {
57			// create settings for compatibility with ajaxSetup
58			settings = jQuery.extend(settings, jQuery.extend({}, jQuery.ajaxSettings, settings));
59
60			var port = settings.port;
61
62			switch (settings.mode) {
			0 ignored issues – show Coding Style introduced 2016-07-05 12:28 UTC by Report Bug Copy Issue Report As per coding-style, `switch` statements should have a `default` case. Loading history...
63			case "abort":
64			if (pendingRequests[port]) {
65			pendingRequests[port].abort();
66			}
67			return pendingRequests[port] = ajax.apply(this, arguments);
68			case "queue":
69			var _old = settings.complete;
70			settings.complete = function () {
71			if (_old)
72			_old.apply(this, arguments);
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-05 12:28 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
73			jQuery([ajax]).dequeue("ajax" + port);
74			;
75			};
76
77			jQuery([ajax]).queue("ajax" + port, function () {
78			ajax(settings);
79			});
80			return;
81			case "sync":
82			var pos = synced.length;
83
84			synced[pos] = {
85			error: settings.error,
86			success: settings.success,
87			complete: settings.complete,
88			done: false
89			};
90
91			syncedData[pos] = {
92			error: [],
93			success: [],
94			complete: []
95			};
96
97			settings.error = function () {
98			syncedData[pos].error = arguments;
99			};
100			settings.success = function () {
101			syncedData[pos].success = arguments;
102			};
103			settings.complete = function () {
104			syncedData[pos].complete = arguments;
105			synced[pos].done = true;
106
107			if (pos == 0 \|\| !synced[pos - 1])
108			for (var i = pos; i < synced.length && synced[i].done; i++) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-05 12:28 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
109			if (synced[i].error) synced[i].error.apply(jQuery, syncedData[i].error);
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-05 12:28 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
110			if (synced[i].success) synced[i].success.apply(jQuery, syncedData[i].success);
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-05 12:28 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
111			if (synced[i].complete) synced[i].complete.apply(jQuery, syncedData[i].complete);
			0 ignored issues – show Coding Style Best Practice introduced 2016-07-05 12:28 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
112
113			synced[i] = null;
114			syncedData[i] = null;
115			}
116			};
117			}
118			return ajax.apply(this, arguments);
119			};
120
121			})(jQuery);
122

mambax7 / references

Push — master ( 369c90...324e29 )

$.ajax B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like